September release - #146
Conversation
remove glob use header detection suggested by Clang
[skip ci]
[skip ci] This reverts commit a27e1d5.
There was a problem hiding this comment.
Shouldn't this bump the compat for t8code_jll.jl in Project.toml to "="4.0.9"?
Do you want to put this into v0.10.0 of T8code.jl or release a version v0.10.0 including the August release and make the September release a new version (v0.10.1 if it is non-breaking)?
To be on the safe side, I would suggest:
- create a new release v0.10.0 of T8code.jl
- rerun CI in trixi-framework/Trixi.jl#3290 after the release is out
- if CI is green merge that PR
-
create a new PR in Trixi.jl using the September releasenot needed - run downstream tests here against the branch from the September release PR in Trixi.jl
- if the test is green, merge this PR
- release v0.10.1 (or v0.11.0?) of T8code.jl
-
rerun CI in the September release PR in Trixi.jlnot needed -
if green merge itnot needed - Finally, we are up to date again with t8code 🥳 ... for a few days at least 😅
Or do you have another plan?
|
Yes, the compat was missing. Thanks! And thanks a lot for the great guide! |
|
Downstream test was successful: https://github.com/DLR-AMR/T8code.jl/actions/runs/36723668114 Actually, there is no change required on the Trixi side. We can just release v0.10.1 and it should be picked up without problems. |
|
BTW, how can we close #147? |
Ah makes sense, great! |
2 participants
Not too much happening this time.
Closes #147.