Skip to content

Invalid use of shallow option and commit hash for FetchContent #2453

Description

@benegee

Bug report

In https://github.com/DLR-AMR/t8code/blob/main/cmake/thirdparty.json we use a shallow flag, mapping to GIT_SHALLOW, and commit hashes in ref (mapping to GIT_TAG ).

According to the docs

If GIT_SHALLOW is enabled then GIT_TAG works only with branch names and tags. A commit hash is not allowed.

While it just works nonetheless, it has the annoying side effect that SC_VERSION is currently set to 0.0.0 because sc's git-version-gen, based on git describe, cannot figure out the latest tag.

Estimated priority

"Priority: medium" Should be solved within half a year

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority:mediumShould be solved within half a yearworkload:lowWould take half a day or less

    Type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions