Minor updates to dsMetadata directive to sanitize metadata - #6183
Merged
Conversation
tdonohue
added
bug
1 APPROVAL
…tag has role=presentation
Contributor
|
Successfully created backport PR for |
tdonohue
removed
the
port to dspace-10_x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
dsMetadatadirective added in Add lang attribute to elements showing metadata values #4776 in DSpace 10.0Description
This PR updates the
dsMetadatadirective to use out-of-the-box Angular sanitization of all metadata values. Includes tests to verify the expected behavior.The commits in this PR were all written by @jensvannerum and I'm just submitting on his behalf.
Instructions for Reviewers
NOTE: As I did not write this code (again it was written by @jensvannerum), I've already done review & testing of the code within this PR. I've verified no change in behavior in the UI. So, assuming all tests pass in GitHub, I'll merge this immediately.