Explicitly add chokidar, readdirp and yaml as dev dependencies to solve dependabot issues - #6186
Open
tdonohue wants to merge 1 commit into
Open
Explicitly add chokidar, readdirp and yaml as dev dependencies to solve dependabot issues#6186tdonohue wants to merge 1 commit into
chokidar, readdirp and yaml as dev dependencies to solve dependabot issues#6186tdonohue wants to merge 1 commit into
Conversation
…pm install --save-dev"
Member
Author
|
@alanorth : Pinging you on this because I think this should finally fix the Thoughts welcome. As I noted above, if we find this works for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recently, in every PR it creates,
dependabotwill attempt to remove thechokidar,readdirpandyamldependencies from ourpackage-lock.jsonfile because they are not explicitly used in dspace-angular (as they are transitive dependencies).However, removing these dependencies causes immediate errors in
npm installbecause all three dependences are required by Angular (and a few other direct dependencies).Examples of
dependabotPRs which attempt to remove these dependencies include the following:(This currently occurs on almost EVERY
dependabotPR against themain,dspace-10_xanddspace-9_xbranches)This PR attempts to resolve the issue by adding all three as development dependencies, which should make it clear to
dependabotthey are needed.NOTE: Because this impacts several branches, this PR will need to be ported to
dspace-10_xanddspace-9_x. It's likely it will need to be recreated on each branch using the above commands as these branches do not have identical dependencies. It does NOT need to be ported to 8.x because that usesyarn, and thisdependabotissue seems to be specific tonpm.NOTE 2: After this PR is merged, every
dependabotPR againstmainwill need to be recreated via@dependabot recreate. That should tell dependabot to use the updated packaging settings & hopefully resolve the issues.Instructions for Reviewers
npm installprocess as well as the build (e.g.npm run build:prod) or running of the UI (e.g.npm run serve:ssr).