Skip to content

Treat an undecided rule as no rule #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylercschneider merged 1 commit into from
Jul 29, 2026
Merged

Treat an undecided rule as no rule #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/event_engine/processing_rules.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def for(event_name:, pack:)
end

def any?
!@default.nil? || @packs.any? || @events.any?
processor_names.any?
end

def processor_names
Expand Down
4 changes: 4 additions & 0 deletions test/lib/event_engine/processing_rules_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ def rules_file(contents)
refute_predicate ProcessingRules.new, :any?
end

test "reports no rules when every event is listed but undecided" do
refute_predicate ProcessingRules.new(events: { cow_fed: nil, barn_built: nil }), :any?
end

test "loads the rules from a yaml file" do
path = rules_file(<<~YAML)
default: inline
Expand Down
Loading