Repository navigation
Fix versioned event lookup after booting from the catalog - #258
Merged
Merged
Conversation
EventSchemaJsonLoader returned a SchemaRegistry, which load_from_schema! stored where an EventSchema belongs, so a versioned lookup after boot called schema_for on a registry and raised NoMethodError. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V
reset! left @event_schema as a plain Hash, so registering into a reset registry raised NoMethodError. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V
Verified failing against the previous loader with NoMethodError: undefined method `schema_for'. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One Sentence Summary
A developer using the gem can ask for a specific version of an event when emitting it, instead of hitting an error.
ACs Covered
Decision Log
Should the twelve open issues be closed or deleted?
Should the JSON loader keep returning a registry, or return the schema its callers assign?
Code Example
Not relevant.
Out of Scope
Not relevant.
Ticket Billed Against
Not specified.
Generation Metadata
Scribe: pr-scribe
96461d7Rules: pr-body
de72862, writing-stylef190206Model:
claude-opus-5[1m], cc2.1.261