Repository navigation
Carry registered schema slices through boot - #259
Closed
tylercschneider wants to merge 4 commits into
Closed
tylercschneider wants to merge 4 commits into
tylercschneider wants to merge 4 commits into
Conversation
boot_from_schema! replaced the global registry with a fresh one holding only the host catalog, so every schema registered by register_slice! during initialization was discarded before the app served a request. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V
Passed on arrival; it holds the order-independence the carry-over is there to give. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V
Verified failing without the duplicate guard with DuplicateEventNameError. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V
Collaborator
Author
|
Closing unmerged. Reverting the related change on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One Sentence Summary
A developer whose gem registers its own events no longer loses them when the host application boots.
ACs Covered
Decision Log
When boot carries a registered slice into the new registry, what happens to an event the committed catalog already has?
Code Example
Not relevant.
Out of Scope
Not relevant.
Ticket Billed Against
Not specified.
Generation Metadata
Scribe: pr-scribe
96461d7Rules: pr-body
de72862, writing-stylef190206Model:
claude-opus-5[1m], cc2.1.261🤖 Generated with Claude Code
https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V