Repository navigation
Restore versioned event lookup and release 0.2.2 - #261
Merged
Merged
Conversation
Reverts the revert in #260. Every helper generated by event_engine-event_definition takes event_version: and forwards it to emit, so any pack consumer passing a version hits the NoMethodError on 0.2.1. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V
The suite's existing coverage built registries by hand or faked the definition port, so nothing exercised the call shape event_engine-event_definition actually generates. Verified failing without the loader fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One Sentence Summary
A developer using the gem can ask for a specific version of an event when emitting it, instead of the call failing outright.
ACs Covered
Decision Log
Should the registry type fix that pull request #260 reverted be restored?
Code Example
Not relevant.
Out of Scope
Not relevant.
Ticket Billed Against
Not specified.
Generation Metadata
Scribe: pr-scribe
96461d7Rules: pr-body
de72862, writing-stylef190206Model:
claude-opus-5[1m], cc2.1.261🤖 Generated with Claude Code
https://claude.ai/code/session_01XJgL65rDiKpStHjHEKPo5V