Skip to content

Check a review against the work item - #342

Merged
tylercschneider merged 10 commits into
mainfrom
feature/review-against-work-item
Nov 4, 2026
Merged

tylercschneider merged 10 commits into
mainfrom
feature/review-against-work-item

Conversation

@tylercschneider

Copy link
Copy Markdown
Collaborator

One Sentence Summary

An owner whose repo keeps its work in dyb_web now gets a pull request review that checks the change against the work item's acceptance criteria, as it already does for a GitHub issue.

ACs Covered

  • A review of a pull request on a work item's branch reports conformance against that work item's criteria.
  • A pull request whose branch names no work item is reported as having no ticket.
  • A review in a repo that does not keep its work in dyb_web checks the GitHub issue exactly as before.

Decision Log

Are the review check and status line units still wanted now that a work item can be taken by hand?

Both are still built, rather than dropped because conductor runs the pipeline.

How does a review find the work item a pull request belongs to?

It reads the number at the start of the pull request's branch and accepts the work item only when that item's branch matches exactly, rather than reading a trailer from the pull request body.

Code Example

Not relevant.

Out of Scope

  • Ticking criteria in dyb_web is not done, since dyb_web has no criteria boxes to tick.

Ticket Billed Against

Not specified.

Tokens Used

Not measured.

Effort

Not measured.

Time Spent

Not measured.

Closes #327


Generation Metadata

Scribe: pr-scribe 9d1ee89
Rules: pr-body 9d1ee89, draft-reading 0d470c5, writing-style c3c2f61
Model: claude-sonnet-5-5, cc 2.1.314

🤖 Generated with Claude Code

tylercschneider and others added 10 commits November 4, 2026 13:14
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ther branch

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… for

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…icket

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tylercschneider
tylercschneider merged commit 46b8355 into main Nov 4, 2026
1 check passed
@tylercschneider
tylercschneider deleted the feature/review-against-work-item branch November 4, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check a review against the work item

1 participant