Skip to content

cli: keep --name separate from group name args - #38

Merged
devin-ai-integration[bot] merged 1 commit into
mainfrom
devin/1791785361-group-name-arg
Oct 12, 2026
Merged

devin-ai-integration[bot] merged 1 commit into
mainfrom
devin/1791785361-group-name-arg

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Options is flattened into Cli with a global --name / ENTANGLE_NAME (the particle name). The positional name in group create|invite|members|leave had the same clap arg id, name, so the group name silently overwrote the particle name. As a result, entangle group create work recorded the creator as work (this machine), and joiners printed Joined work (…) via work. whether or not --name was passed.

// group create / invite / members / leave
#[arg(id = "group_name", value_name = "NAME")]
name: String,

Help still shows <NAME>. I checked every other subcommand in main.rs, peer.rs and repeater.rs against the global Options ids and found no other collisions.

Tests: Cli::try_parse_from covers create and invite with and without --name, and members with --name, with ENTANGLE_NAME cleared under a lock.

Manual check: with a fresh data dir and no --name, group members work now shows devin-box-580e (this machine).

Existing groups: a group created before this fix keeps the wrong creator name in its stored roster.

Link to Devin session: https://app.devin.ai/sessions/2e5afab1127347e783891657f1394118
Open in Devin Desktop: https://app.devin.ai/desktop/session/2e5afab1127347e783891657f1394118?variant=devin
Requested by: @DailenG

Co-Authored-By: Dailen Gunter <daileng@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 75d0834e-24ce-4d21-a4df-3dd06f9b18cb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration
devin-ai-integration Bot merged commit 91e478e into main Oct 12, 2026
5 checks passed
@devin-ai-integration devin-ai-integration Bot mentioned this pull request Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant