Repository navigation
cli: keep --name separate from group name args - #38
Merged
Merged
Conversation
Co-Authored-By: Dailen Gunter <daileng@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Merged
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optionsis flattened intoCliwith a global--name/ENTANGLE_NAME(the particle name). The positionalnameingroup create|invite|members|leavehad the same clap arg id,name, so the group name silently overwrote the particle name. As a result,entangle group create workrecorded the creator aswork (this machine), and joiners printedJoined work (…) via work.whether or not--namewas passed.Help still shows
<NAME>. I checked every other subcommand inmain.rs,peer.rsandrepeater.rsagainst the globalOptionsids and found no other collisions.Tests:
Cli::try_parse_fromcovers create and invite with and without--name, andmemberswith--name, withENTANGLE_NAMEcleared under a lock.Manual check: with a fresh data dir and no
--name,group members worknow showsdevin-box-580e (this machine).Existing groups: a group created before this fix keeps the wrong creator name in its stored roster.
Link to Devin session: https://app.devin.ai/sessions/2e5afab1127347e783891657f1394118
Open in Devin Desktop: https://app.devin.ai/desktop/session/2e5afab1127347e783891657f1394118?variant=devin
Requested by: @DailenG