Repository navigation
Groups: leave notices, member removal, rekey, admin handoff (signed update chain, key epochs) - #41
Merged
Conversation
Co-Authored-By: Dailen Gunter <daileng@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Dailen Gunter <daileng@gmail.com>
Co-Authored-By: Dailen Gunter <daileng@gmail.com>
Co-Authored-By: Dailen Gunter <daileng@gmail.com>
Co-Authored-By: Dailen Gunter <daileng@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 5 of #34. Design: #34 (comment)
Key epochs, stable group ID. The group ID (the directory name) is fixed when the group is created and no longer derives from the current key. Each admin action bumps
meta.epoch, and may rotate the key. Members keep the last 16 old keys (keys.json) and the last 17 signed updates (updates.json). Every epoch a peer can still negotiate therefore has a complete update chain.0x02is unauthenticated. Its only effects are a log line and backoff (TransportError::TooFarBehind/PeerTooFarBehind).dialthen moves on to the next shared group.Signed
GroupUpdatechain (entangle-core):epoch,key_hex,admin,admin_sign_key,revoked(the full set),kind,issued_by.SHA-256("entangle-sign-v1" || static_private).apply_updates): onlyepoch == current+1signed by the current admin. A handoff must name a current member, and itsadmin_sign_keymust match that member's record.updates_since, served only to current members).GroupUpdates/GroupUpdatesAck, then redials.Membership:
DeclineReason::Removed). An admin re-invite un-revokes it.GroupInfocarries the inviter's epoch, and after SPAKE2 the joiner replaces its copy atomically, keeping the local name.CLI (human-only, single-keypress confirm):
group remove <group> <member>,group rekey <group>,group admin <group> <member>: admin-only.group leave: sendsLeavethrough the running node. The admin must hand off first if other members remain.groups/.status/<id>.json.Breaking: the protocol, preface and storage versions all change. 0.6 groups report
GroupError::Outdatedand must be recreated (group leavestill deletes them). The repeater session uses the first active group that is in the key ring.Docs: playbook 10, SETUP, AGENT_SETUP (agents never run these commands), ARCHITECTURE, troubleshooting.
Tests: 181 pass in a serialized run (
cargo test --workspace -- --test-threads=1).normal_particles_prefer_direct_route_with_repeater_availablewas traced to this branch: main passed 3/3, the branch 2/3.Link to Devin session: https://app.devin.ai/sessions/2e5afab1127347e783891657f1394118
Open in Devin Desktop: https://app.devin.ai/desktop/session/2e5afab1127347e783891657f1394118?variant=devin
Requested by: @DailenG