Repository navigation
What's new shows every release since the version you updated from - #141
Conversation
build.rs now embeds the whole CHANGELOG.md; whats_new::notes picks the range when the window opens, from the version read_and_record already had on record (it used to discard it). Versions compare as numeric major.minor.patch, so a packaged install's four-part 1.4.2.0 matches the changelog's 1.4.2; an unparseable, equal or newer record falls back to the current release as before.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
📝 Summary
Merge Risk: 🔵 Low · up to On development builds, the What's New window can say it covers one more release than it actually lists. Release builds are unaffected, so merge risk is low. Pre-merge checks ·
|
… releases it jumped over Review finding on #141: a build whose version has no section of its own yet (changes under Unreleased), updated from an older record, listed the intervening releases but dropped Unreleased, so the window showed history without the running build's own newest changes.
|
@coderabbitai the finding is fixed in 27064a8 (Unreleased shown ahead of the releases a development build jumped over); thread replied to and resolved. Please re-review the current head. |
|
If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit!
|
…mped release Review findings on #141: sections_since added Unreleased to the release list, so the range line over-counted (one release reported as two) and, with no Unreleased section, a single jumped release was discarded and the window came back empty. It now returns the sections and the number of numbered releases separately; Unreleased is shown ahead of them for a development build but never counted, and a range that has releases is always returned.
|
@coderabbitai approve |
✅ Action performedComments resolved and changes approved. |
Bumps `version` to 1.5.0 (`Cargo.toml`, `Cargo.lock`) and moves Unreleased under `## [1.5.0] - 2026-10-12`. A minor bump, as CONTRIBUTING.md asks for user-visible features. Included since 1.4.2: - The What's new window shows every release since the version you updated from (#141). - Syntax colour for `.json`, `.jsonc` and `.json5` files, up to 5 MB (#113, #142). Not included, by decision: the Explorer "Open in Tachyon" command (#123), closed as not planned. The `v1.5.0` tag is **not** pushed; it waits for owner approval and the release.yml dry run (run 38321579285). <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/daileng/tachyon/pull/143" target="_blank"><picture><source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-devin-review-dark.svg?v=4"><img src="https://static.devin.ai/assets/gh-devin-review-light.svg?v=4" alt="Devin Review"></picture></a> <!-- devin-review-badge-end -->
Updating across several releases (1.3.0 to 1.4.2) showed only the newest release notes. The old version was read from the record file and then thrown away.
What changes
build.rsembeds the wholeCHANGELOG.mdinstead of one version's section.whats_new::notes(from, current)builds the window text when it opens: every release newer thanfromup tocurrent, newest first, under the usual heading, plus a line "You updated from X: this covers all N releases since." when more than one.read_and_recordnow also returns the version that was on record.major.minor.patch(changelog::parse_version), so a packaged install's four-part1.4.2.0matches the changelog's1.4.2, and a nightly of the same release is not an update.Unreleasedfor a dev build). The palette row passes nofrom, so it shows the current release only.Cost
The changelog (about 40 KB) was already read at build time; it is now embedded whole. The range is computed once, after the first frame, only when the window opens, so the startup budget is untouched.
Verified
cargo xtask ci(40 tests intachyon, including ranges, four-part versions, every fallback, non-version headings) and Windows clippy pass.1.3.0): the window opened as "What's new in Tachyon 1.4.2" with the range line and the 1.4.2, 1.4.1 and 1.4.0 sections, newest first; the record was rewritten to1.4.2.1.4.2.0path is covered by a unit test, not run for real).