Repository navigation
feat(repo): enforce PR-first landing for main - #36
Merged
Merged
Conversation
All changes now land on main through a pull request; direct pushes are disallowed (admin keeps a pull_request bypass as an escape hatch). The ruleset restricts merges to squash and requires lint, type-check, test, and build. ADR-0004 supersedes ADR-0001 in full. - add a build job to ci.yml (web app + md-web-cli) - run sync-upstream unit tests before the verify gate - write ADR-0004 and mark ADR-0001 superseded; update AGENTS.md, GLOSSARY.md Landing upstream as a merge commit is deferred (see #34); adding verify to required checks waits on the gate going green (see #33).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforce PR-first landing for
main. Per ADR-0004, every change now enters via a pull request — direct pushes are disallowed (the repository admin keeps apull_requestbypass as an escape hatch for broken CI, not as the normal path). ADR-0004 fully supersedes ADR-0001.This commit carries the repository-side half; the enforcement itself is already live on the GitHub ruleset (
Protect main (PR + status checks)):allowed_merge_methods: ["squash"], admin bypasspull_request, required checkslint/type-check/test/build.What this commit changes:
buildjob (web app viapnpm web build+md-web-clibundle) so a broken bundle is caught on a PR, not after it lands.md-web-cliunit tests before the verify gate, so a red gate never hides a CLI test regression; document the squash landing and the deferred merge-commit option in the header.Fork-local change→Fork-local package.Type of Change
Test Procedure
allowed_merge_methods=["squash"], bypasspull_request, checkslint,type-check,test,build).pnpm wcli:verifygate is currently red (0/2 fixtures, see ADR-0003); thebuildjob does not run the gate, so it is expected to pass.Related tracking:
verify→ required checks waits on the gate going green (see #33); landing upstream as a merge commit is deferred (see #34).Pre-flight Checklist
pnpm run lintpasses