Feat/struct size info on hover - #1662
Closed
giuinktse7 wants to merge 35 commits into
Closed
giuinktse7 wants to merge 35 commits into
giuinktse7 wants to merge 35 commits into
Conversation
- track if field layouts are known - support more types like scalars, aliases, distinct types, and fixed arrays - suppress size information for unsupported field types
Detect recursive by-value type layouts and treat them as unknown instead of recursing indefinitely. This prevents OLS from crashing when hovering malformed self-referential or mutually recursive structs.
Calculate SIMD vector layouts using Odin’s target-specific alignment rules.
Keep completion and signature documentation free of hover-only layout details. This also avoids unnecessary recursive layout calculations.
Render size and alignment as a distinct Markdown section so clients do not combine layout metadata with the struct's documentation.
Add layout mappings for UTF-16 strings, runtime descriptor types, fixed-width booleans, and endian-specific integers and floats.
Support configuration directives, conversions, conditionals, size_of, and align_of when calculating layout attributes and container bounds.
Return an unknown layout when a complement operand is unsigned, context-dependent, or cannot be resolved. This prevents hover information from reporting sizes based on incorrect integer semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.