Repository navigation
fix(shared): trim with a linear loop instead of a backtracking regex - #239
Merged
Merged
Conversation
CodeQL flagged /\/+$/ and /^-+|-+$/ as polynomial ReDoS in form-links and the API reference. Their inputs are server config and fixed route strings, so nothing was exploitable, but the loops are just as short. Signed-off-by: Josue Hernandez <josue@daptatech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL flags three
js/polynomial-redosalerts on the release PR (#238):/\/+$/inform-links.tsand inapiCurl, and/^-+|-+$/ginapiAnchor.Their inputs are server configuration and fixed route strings, so none was exploitable. A short linear loop does the same job and clears the alerts.
packages/shared/src/trim.tswithtrimTrailingandtrimChar(not exported from the package index).form-linksandapi-referencespecs pass).trim.spec.tscovers the edge cases and a 200,000-character run.🤖 Generated with Claude Code