Skip to content

chore(release): prepare 8.x-1.0-rc2 - #36

Merged
Decipher merged 2 commits into
8.x-1.xfrom
feature/rc2-release-prep
Sep 7, 2026
Merged

chore(release): prepare 8.x-1.0-rc2#36
Decipher merged 2 commits into
8.x-1.xfrom
feature/rc2-release-prep

Conversation

@Decipher

@Decipher Decipher commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

Release preparation for 8.x-1.0-rc2. The CHANGELOG gets its release header, and the "Temporary file location" description on both forms now says the same as the README section from #3619767.

Changes

  • CHANGELOG.md: ## Unreleased becomes ## 8.x-1.0-rc2 - 2026-09-07, with two lines added under Changed for the README rewrite and the form text below.
  • src/Form/SettingsForm.php and src/Hook/FieldConfigEditForm.php: the description no longer recommends private:// for image previews. Previews work under temporary:// since #3121826. It now gives the same advice as the README: temporary:// first, private:// when that does not suit the server, never public:// on a site with private files. The em dash is gone.

Testing

  • make lint clean: PHPCS, PHPStan, Rector, Twig CS Fixer, ESLint, CSpell.
  • SettingsFormTest (7 tests) renders the form with the new text.
  • No test asserts the old description, so nothing else changes.

Summary by CodeRabbit

  • Documentation
    • Updated release identification to version 8.x-1.0-rc2, dated September 7, 2026.
    • Clarified guidance for temporary file storage, including when to use temporary:// or private://.
    • Updated settings guidance to explain upload timing, image previews, and public URL considerations.
    • Removed outdated image-preview guidance.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 7ce24b02-f585-4f6e-b6aa-87747b30fd08

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 86756636-0679-4df7-ae77-1743d6df848e

📥 Commits

Reviewing files that changed from the base of the PR and between c5e645d and efd33c8.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • src/Form/SettingsForm.php
  • src/Hook/FieldConfigEditForm.php

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change updates temporary file location guidance in two forms and records the related documentation changes in the changelog. It recommends temporary://, permits private:// as a fallback, and explains the risk of public:// before entity save.

Changes

Temporary file location guidance

Layer / File(s) Summary
Temporary file guidance updates
src/Form/SettingsForm.php, src/Hook/FieldConfigEditForm.php, CHANGELOG.md
The form descriptions now explain the upload and save flow, recommend temporary://, allow private:// as a fallback, and warn about public:// on private-file sites. The changelog records the release and documentation updates.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to efd33

The release notes and temporary-file guidance now consistently recommend temporary://, describe private:// as a fallback, and warn against temporary public exposure. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: preparing the 8.x-1.0-rc2 release. It is concise and specific.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/rc2-release-prep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.66%. Comparing base (c5e645d) to head (efd33c8).

Additional details and impacted files
@@           Coverage Diff            @@
##           8.x-1.x      #36   +/-   ##
========================================
  Coverage    83.66%   83.66%           
========================================
  Files           20       20           
  Lines          796      796           
========================================
  Hits           666      666           
  Misses         130      130           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Decipher

Decipher commented Sep 7, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Decipher

Decipher commented Sep 7, 2026

Copy link
Copy Markdown
Owner Author

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Decipher
Decipher merged commit 2da2b04 into 8.x-1.x Sep 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant