chore(release): prepare 8.x-1.0-rc2 - #36
Conversation
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change updates temporary file location guidance in two forms and records the related documentation changes in the changelog. It recommends ChangesTemporary file location guidance
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to The release notes and temporary-file guidance now consistently recommend temporary://, describe private:// as a fallback, and warn against temporary public exposure. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.x-1.x #36 +/- ##
========================================
Coverage 83.66% 83.66%
========================================
Files 20 20
Lines 796 796
========================================
Hits 666 666
Misses 130 130 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@CodeRabbit review |
|
Summary
Release preparation for
8.x-1.0-rc2. The CHANGELOG gets its release header, and the "Temporary file location" description on both forms now says the same as the README section from #3619767.Changes
CHANGELOG.md:## Unreleasedbecomes## 8.x-1.0-rc2 - 2026-09-07, with two lines added under Changed for the README rewrite and the form text below.src/Form/SettingsForm.phpandsrc/Hook/FieldConfigEditForm.php: the description no longer recommendsprivate://for image previews. Previews work undertemporary://since #3121826. It now gives the same advice as the README:temporary://first,private://when that does not suit the server, neverpublic://on a site with private files. The em dash is gone.Testing
make lintclean: PHPCS, PHPStan, Rector, Twig CS Fixer, ESLint, CSpell.SettingsFormTest(7 tests) renders the form with the new text.Summary by CodeRabbit
8.x-1.0-rc2, dated September 7, 2026.temporary://orprivate://.