Repository navigation
Consolidate pVisor binaries and replace hyperfine benchmarks - #32
Merged
Merged
Conversation
Move `pvisor-cache` under `pvisor cache` subcommands, with the cache service now owned by `pvisor-daemon serve --cache`. The daemon supervises the cache worker, waits for post-bind readiness, and stops or fails with it. Sandbox and memory-pool options now require explicit `--sandbox` selection. Drop the standalone `pvisor-overlayfs` diagnostic CLI. Update packaging, CI, benchmarks, and docs to match the new executable set and shared native build pipeline.
Measure process and replay benchmark conditions with a Python timer that times only the subject argv, keeping preparation and correctness hooks outside the interval. Trial records, hooks, and recomputed statistics are audited before publication. Remove hyperfine installation from CI and benchmark workflows, drop semspec hyperfine pointer/scale support, and make script rows the sole table command form.
reiase
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate the executable set: move cache management into
pvisor cache, letpvisor-daemon serve --cachesupervise cache serving, and remove the standalonepvisor-cacheandpvisor-overlayfsbinaries. Sandbox and memory-pool options require explicit--sandboxselection. Update the shared build pipeline, packaging and documentation accordingly.Replace hyperfine with a Python standard-library command timer for process and replay benchmarks. Preserve warmups, untimed preparation/correctness hooks, raw per-trial evidence and audited statistics; remove hyperfine installation and export parsing. Historical results retain their original timing provenance and cannot be mixed with new measurements.
Fix CI lifecycle and timing assumptions: stop the default-build Host listener before switching executable digests, and allow time for sandbox startup and filesystem synchronization in regression tests without relaxing correctness assertions.
Validation:
os.sched_getaffinityunavailable).