Repository navigation
Conversation
A not_required record of a set whose campaign token names no challenge run said "Not re-checked: no challenge was required." That reason was written for records a challenge plan exempted. A set sealed with `tally.py --unchallenged` (#183) had no challenge at all, and its hot passages' records are ones every plan requires, so the sentence now gives no reason when no challenge run is named. With one named it still says the run did not require it.
Deicyde
marked this pull request as ready for review
November 13, 2026 12:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #183. A record whose challenge value is
not_required, in a set whose campaign token names no challenge run, read "Not re-checked: no challenge was required." That reason was written for records a challenge plan exempted. A set sealed withtally.py --unchallengedhad no challenge at all, and its subject and central passages' records are ones every plan requires, so the review of #183 found the sentence misleading there.What changes. With no challenge run named, the sentence is now "Not re-checked." and gives no reason. With one named it still says "Not re-checked: challenge run X did not require it." The Details fold's run line already said "not re-checked by a challenge run" for such sets and is unchanged.
Release.
wiki/src/articles-render.tsis release-affecting (site/ops/brain_release_authority.py), so this ships only in the next release, with a fresh P1B and Jack's approval. Reader pages are not in the render cache, so no key bump.Checks. A new test renders an unchallenged set's page (token
run:loc-smoke-2, every recordnot_required) and checks both sentences directly. CI on 3dc11cd: worker, python, browser and attribution passed.https://github.com/Deicyde/WikiLean/actions/runs/43426399424