Skip to content

Issue #1922 fix meteogridcopy dump - #1924

Merged
JoerivanEngelen merged 7 commits into
masterfrom
issue_#1922_fix_meteogridcopy_dump
Sep 30, 2026
Merged

JoerivanEngelen merged 7 commits into
masterfrom
issue_#1922_fix_meteogridcopy_dump

Conversation

@JoerivanEngelen

Copy link
Copy Markdown
Contributor

Fixes #1922

Description

This PR does the following:

  • Resolve an issue where pathlib.Path objects were assigned to xarray Datasets, but these cannot be serialized. Therefore enforce these to string.
  • Add sanity check: roundtrip storing and loading for metaswap packages.
  • Provide names as ids to package sanity checks, to have more informative test naming
  • Rename package_sanity files from mf6 module.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example
  • If feature added: Added feature to API documentation
  • If pixi.lock was changed: Ran pixi run generate-sbom and committed changes

@sonarqubecloud

Copy link
Copy Markdown

@ClaireDons ClaireDons left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JoerivanEngelen
JoerivanEngelen merged commit cfbb3a0 into master Sep 30, 2026
8 checks passed
@JoerivanEngelen
JoerivanEngelen deleted the issue_#1922_fix_meteogridcopy_dump branch September 30, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MeteoGridCopy dump fails when initialized with pathlib.Path

2 participants