refactor: make tiled client smaller - #1665
Open
ZohebShaikh wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1665 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 46 46
Lines 3665 3665
=======================================
Hits 3531 3531
Misses 134 134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ZohebShaikh
marked this pull request as ready for review
September 11, 2026 08:38
ZohebShaikh
commented
Sep 11, 2026
Comment on lines
-17
to
21
| "tiled[client]>=0.2.4", | ||
| "tiled[minimal-client]>=0.2.4", | ||
| "pyarrow", # Needed for TiledWriter | ||
| "pandas", # Needed for TiledWriter | ||
| "ndindex", # Needed for TiledWriter | ||
| "bluesky[plotting]>=1.14.0", # plotting includes matplotlib, required for BestEffortCallback in run plans |
Contributor
Author
There was a problem hiding this comment.
I'm going backwards and forward on whether I should put this in tiled or bluesky-tiled-plugin or just leave it on blueapi level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies reduced by 731M to 522M.
The main thing removed is llvmlite 171.2 MB