Skip to content

Add Jungfrau 9M detector size constants - #2184

Open
ndevenish wants to merge 2 commits into
DiamondLightSource:mainfrom
ndevenish:jungfrau_constants
Open

Add Jungfrau 9M detector size constants#2184
ndevenish wants to merge 2 commits into
DiamondLightSource:mainfrom
ndevenish:jungfrau_constants

Conversation

@ndevenish

Copy link
Copy Markdown
Contributor

The i24 jungfrau is a Jungfrau 9M: 3108 x 3262 pixels of 75um, so 233.1 x 244.65 mm.

Instructions to reviewer on how to test:

  1. import dodal.devices.detector.det_dim_constants
  2. print(dodal.devices.detector.det_dim_constants.ALL_DETECTORS["JUNGFRAU_9M"])

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

The i24 commissioning jungfrau is a PSI Jungfrau 9M: 3108 x 3262 pixels of 75um,
so 233.1 x 244.65 mm. Recorded the way every other detector's dimensions are, so
that anything needing them - a resolution calculation, in the case at hand - can
look them up by type rather than carrying its own copy.
@ndevenish
ndevenish requested a review from a team as a code owner August 24, 2026 11:08
@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.20%. Comparing base (c9355dd) to head (b2f51bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2184   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files         367      367           
  Lines       14589    14597    +8     
=======================================
+ Hits        14473    14481    +8     
  Misses        116      116           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant