Add Jungfrau 9M detector size constants - #2184
Open
ndevenish wants to merge 2 commits into
Open
Conversation
The i24 commissioning jungfrau is a PSI Jungfrau 9M: 3108 x 3262 pixels of 75um, so 233.1 x 244.65 mm. Recorded the way every other detector's dimensions are, so that anything needing them - a resolution calculation, in the case at hand - can look them up by type rather than carrying its own copy.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 367 367
Lines 14589 14597 +8
=======================================
+ Hits 14473 14481 +8
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The i24 jungfrau is a Jungfrau 9M: 3108 x 3262 pixels of 75um, so 233.1 x 244.65 mm.
Instructions to reviewer on how to test:
import dodal.devices.detector.det_dim_constantsprint(dodal.devices.detector.det_dim_constants.ALL_DETECTORS["JUNGFRAU_9M"])Checks for reviewer
dodal connect ${BEAMLINE}