Raise AcquisitionStop timeout for commissioning Jungfrau - #2186
Open
ndevenish wants to merge 1 commit into
Open
Conversation
AcquisitionStop takes ~20s to complete on the commissioning IOC, longer than ophyd-async's 10s Command default, so unstage() raised TimeoutError after the stop had in fact been accepted. That aborted ensure_stopped() before it reset pedestal mode, left the zebra tidy-up unconfirmed, and dropped any remaining transmissions in the scan request.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2186 +/- ##
==========================================
+ Coverage 99.16% 99.20% +0.04%
==========================================
Files 354 367 +13
Lines 13842 14591 +749
==========================================
+ Hits 13726 14475 +749
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AcquisitionStop takes ~20s to complete on the commissioning IOC, longer than ophyd-async's 10s Command default, so unstage() raised TimeoutError after the stop had in fact been accepted. That aborted ensure_stopped() before it reset pedestal mode, left the zebra tidy-up unconfirmed, and dropped any remaining transmissions in the scan request.
Fixes #ISSUE
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}