Skip to content

Update i05 and i05-1 analyser slit device enum values to reflect beamline - #2196

Merged
Villtord merged 1 commit into
mainfrom
I05_update_slits_enum
Sep 4, 2026
Merged

Update i05 and i05-1 analyser slit device enum values to reflect beamline#2196
Villtord merged 1 commit into
mainfrom
I05_update_slits_enum

Conversation

@Villtord

@Villtord Villtord commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #2195

Update i05 HR branch analyser_set enum values to a new set identical to Nano branch.

Instructions to reviewer on how to test:

  1. Confirm dodal connect i05 connects analyser_slits
  2. Confirm dodal connect i05-1 connects analyser_slits

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Villtord
Villtord requested a review from a team as a code owner September 4, 2026 11:02
@Villtord Villtord linked an issue Sep 4, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.33%. Comparing base (fc58b6e) to head (40729c7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2196      +/-   ##
==========================================
- Coverage   99.33%   99.33%   -0.01%     
==========================================
  Files         367      367              
  Lines       14380    14379       -1     
==========================================
- Hits        14285    14284       -1     
  Misses         95       95              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oliwenmandiamond oliwenmandiamond left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

@oliwenmandiamond oliwenmandiamond changed the title update slit enum values to actual from the beamline Update i05 and i05-1 analyser slit device enum values to reflect beamline Sep 4, 2026
@Villtord
Villtord merged commit 73c97ef into main Sep 4, 2026
11 checks passed
@Villtord
Villtord deleted the I05_update_slits_enum branch September 4, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update analyser_slit enum values set on I05

2 participants