I24 update for plans - #1821
Open
adaudon wants to merge 3 commits into
Open
I24 update for plans#1821adaudon wants to merge 3 commits into
adaudon wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1821 +/- ##
=======================================
Coverage 92.97% 92.97%
=======================================
Files 165 165
Lines 9029 9029
=======================================
Hits 8395 8395
Misses 634 634
🚀 New features to boost your workflow:
|
noemifrisina
approved these changes
Sep 11, 2026
noemifrisina
left a comment
noemifrisina
left a comment
Contributor
There was a problem hiding this comment.
lgtm, just one comment really, take it or leave it
| magnitude = -magnitude | ||
|
|
||
| yield from bps.abs_set(pmac.z, magnitude, wait=True) | ||
| yield from bps.rel_set(pmac.z, magnitude, wait=True) |
Contributor
There was a problem hiding this comment.
Any particular reason for using this instead of bps.mvr ? (relative move)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bugs with previous change. Plans had issues with not working so these fixes now allows these bluesky plans to activate.
Instructions to reviewer on how to test:
Checks for reviewer