Repository navigation
Minor fixes - #372
Merged
Merged
Minor fixes#372
Conversation
added 2 commits
October 22, 2026 12:06
The modify dates profile still used the old delete_custom_metadata key, which is silently ignored by the dicom rules model. Use custom_metadata_action, matching the base rules.
The modify dates rules are a full copy of the base rules rather than an overlay, so rules added to the base profile must be mirrored there. The test checks that both profiles have the same structure and actions, other than actions changed to modify_date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.