Repository navigation
Update to Node 24 and remove Vue CLI - #550
Merged
Merged
Conversation
Bump client/.nvmrc from 20 to 24 and the CI client job from 20.10.0 to 24 (with actions/setup-node v6), matching the release workflows. Node 20 is end-of-life. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The web app already builds with Vite. Vue CLI was only left as a task runner, so call the tools directly: - lint: eslint over src/, dive-common/, platform/ (add lint:fix) - test: jest with the existing config in package.json - babel.config.js: @babel/preset-env instead of the Vue CLI preset Remove the unused build:package script and vue.config.js, plus the Vue CLI packages and webpack-only loaders (sass-loader, vuetify-loader, worker-loader, vue-cli-plugin-vuetify). This also drops @achrinza/node-ipc, which warned about unsupported engines on Node 24. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BryonLewis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node 24
client/.nvmrc:20→2420.10.0→24,actions/setup-nodev3→v6(matches the release workflows)docker/girder.Dockerfileclient build stage:node:20→node:24Node 20 is end-of-life.
Remove Vue CLI (the app already builds with Vite; Vue CLI was only a task runner)
lint: runseslintdirectly oversrc/ dive-common/ platform/; newlint:fixscript. Note:vue-cli-service lintauto-fixed by default, the newlintonly reports.test: runsjestdirectly with the existing config inpackage.jsonbabel.config.js:@babel/preset-env(current Node) instead of@vue/cli-plugin-babel/preset;@babel/coreand@babel/preset-envadded as devDependenciesbuild:packagescript andvue.config.js, the@vue/cli-*packages, and webpack-onlysass-loader,vuetify-loader,worker-loader,vue-cli-plugin-vuetify. Lockfile drops 443 packages, including@achrinza/node-ipc, which warned about unsupported engines on Node 24.Testing
Locally on Node 24.18.0 / npm 11.16.0:
npm ci: passes, no EBADENGINE warningsnpm run lint: passes, and fails on deliberately introduced errors in.tsand.vuefilesnpm test -- --collect-coverage: 10 suites, 60 tests passingnpm run build:web: buildsThe Docker image build was not run locally.
🤖 Generated with Claude Code