Repository navigation
Keep at most one folder/:id/volview_loadable request in flight. - #115
Merged
Merged
Conversation
The server walks the whole folder subtree to answer, which can take a long time on large trees, and aborting in the browser does not stop that work. Buttons asking about the folder already in flight share its answer, and navigating while a request is in flight only records which folder to check next, so rapid browsing issues at most one further request when the current one finishes. A superseded pending check is dropped, which also keeps a stale answer from updating a newer folder's button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server walks the whole folder subtree to answer, which can take a long time on large trees, and aborting in the browser does not stop that work. Buttons asking about the folder already in flight share its answer, and navigating while a request is in flight only records which folder to check next, so rapid browsing issues at most one further request when the current one finishes. A superseded pending check is dropped, which also keeps a stale answer from updating a newer folder's button.