Repository navigation
Declare access levels on the REST delete guards - #117
Merged
Merged
Conversation
Decorate the guards with access.user, matching the routes they guard; the routes still enforce per-resource access and token scopes. The existing guard tests ran as the first-created user, who is a site admin, so add a test that deletes as a non-admin.
Collaborator
Author
|
The symptom was that a user couldn't delete through the resources endpoint. |
PaulHax
approved these changes
Oct 29, 2026
PaulHax
left a comment
PaulHax
left a comment
Collaborator
There was a problem hiding this comment.
Nice and simple, thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decorate the guards with access.user, matching the routes they guard; the routes still enforce per-resource access and token scopes. The existing guard tests ran as the first-created user, who is a site admin, so add a test that deletes as a non-admin.