Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: DocGrid/docgrid/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제 상황
머지된 #373은 관리자 역할 회수 이후 기존 STOMP 대시보드 구독자의 새 메시지를 차단합니다. 그 대신 브로커가 수신자마다 현재 primary 역할을 동기 조회하므로, 실제 전달 지연과 push 생성량에 미치는 비용을 별도로 측정·기록할 필요가 있었습니다.
이번 PR에 담은 것
테스트 환경 (2026-10-01 실행분)
핵심 관측
50개 구독, 30초 관측, 버전별 3회에서 수신 지연 p95 중앙값은 기존 8.5 ms → #373 버전 2,443.7 ms였습니다. 수신 프레임 중앙값은 5,000 → 588건이었습니다. 연결 오류와 수신한 sequence의 중간 누락은 0건이지만, 동기 팬아웃이 다음 발행을 늦춰 목표한 주기만큼 push가 생성되지 않았습니다. JVM 스택 관찰, Hikari 대여 증가, 낮은 CPU·대기열 표본은 수신자별 동기 DB 확인이 병목이라는 해석을 뒷받침합니다.
검증과 범위
python3 -m unittest -v scripts.opensql.test_websocket_dashboard_evidence: 5/5 통과.git diff --cached --check통과.Closes #374. Related: #373, #371.