Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<!-- Properties related to build/pack -->
<IsPackable>false</IsPackable>
<Version>10.0.13-pre02</Version>
<Version>10.0.13</Version>
<MapsterPluginsTFMs>netstandard2.0;net10.0;net9.0;net8.0</MapsterPluginsTFMs>
<MapsterTFMs>netstandard2.0;net10.0;net9.0;net8.0</MapsterTFMs>
<MapsterEFCoreTFMs>net10.0;net9.0;net8.0</MapsterEFCoreTFMs>
Expand Down
412 changes: 412 additions & 0 deletions src/Mapster.Tests/WhenCachingAttributeMetadata.cs

Large diffs are not rendered by default.

285 changes: 285 additions & 0 deletions src/Mapster.Tests/WhenLookingUpHiddenMembers.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,285 @@
using System;
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using Shouldly;
using Microsoft.VisualStudio.TestTools.UnitTesting;

namespace Mapster.Tests
{
[TestClass]
public class WhenLookingUpHiddenMembers
{
[TestMethod]
public void DropHiddenMembers_CurrentMembers_AreEnumeratedOnce()
{
var members = typeof(Source).GetProperties().Cast<MemberInfo>().ToArray();
var current = new CountingCollection(members);
var result = Filter(members, current);

current.Enumerations.ShouldBe(0);
using (result.GetEnumerator())
current.Enumerations.ShouldBe(0);
result.ToArray().ShouldBe(members);
current.Enumerations.ShouldBe(1);
result.ToArray().ShouldBe(members);
current.Enumerations.ShouldBe(2);
}

[TestMethod]
public void DropHiddenMembers_Source_IsEnumeratedOnce()
{
var members = typeof(Source).GetProperties().Cast<MemberInfo>().ToArray();
var visits = 0;
var source = members.Select(member =>
{
visits++;
return member;
});

var result = Filter(source, members);
visits.ShouldBe(0);
using (result.GetEnumerator())
visits.ShouldBe(0);
result.ToArray().ShouldBe(members);
visits.ShouldBe(members.Length);
}

[TestMethod]
public void DropHiddenMembers_PartialEnumeration_DoesNotTraverseRemainingSource()
{
var member = typeof(Source).GetProperty(nameof(Source.First));
var visits = 0;
var source = Enumerable.Repeat<MemberInfo>(member, 10).Select(item =>
{
visits++;
return item;
});

Filter(source, new[] { member }).First().ShouldBeSameAs(member);
visits.ShouldBe(1);
}

[TestMethod]
public void DropHiddenMembers_HiddenProperty_PreservesInheritedMembersAndOrder()
{
var inherited = typeof(BaseSource).GetProperty(nameof(BaseSource.Inherited));
var hidden = typeof(BaseSource).GetProperty(nameof(BaseSource.Value));
var visible = typeof(DerivedSource).GetProperty(nameof(DerivedSource.Value), BindingFlags.Public | BindingFlags.Instance | BindingFlags.DeclaredOnly);
MemberInfo[] members = { inherited, hidden, visible, inherited };

Filter(members, new MemberInfo[] { visible }).ShouldBe(new MemberInfo[] { inherited, visible, inherited });
}

[TestMethod]
public void DropHiddenMembers_FieldHidesProperty_PreservesMetadataTokenSelection()
{
var hidden = typeof(BaseSource).GetProperty(nameof(BaseSource.Value));
var visible = typeof(FieldSource).GetField(nameof(FieldSource.Value));

Filter(new MemberInfo[] { hidden, visible }, new MemberInfo[] { visible }).ShouldBe(new MemberInfo[] { visible });
}

[TestMethod]
public void DropHiddenMembers_DuplicateCurrentNames_FirstMemberWins()
{
var hidden = typeof(BaseSource).GetProperty(nameof(BaseSource.Value));
var visible = typeof(DerivedSource).GetProperty(nameof(DerivedSource.Value), BindingFlags.Public | BindingFlags.Instance | BindingFlags.DeclaredOnly);

Filter(new MemberInfo[] { hidden, visible }, new MemberInfo[] { visible, hidden }).ShouldBe(new MemberInfo[] { visible });
Filter(new MemberInfo[] { hidden, visible }, new MemberInfo[] { hidden, visible }).ShouldBe(new MemberInfo[] { hidden });
}

[TestMethod]
public void DropHiddenMembers_DifferentlyCasedNames_AreDistinct()
{
var upper = typeof(BaseSource).GetProperty(nameof(BaseSource.Value));
var lower = typeof(CaseSource).GetProperty(nameof(CaseSource.value));

Filter(new MemberInfo[] { upper, lower }, new MemberInfo[] { lower }).ShouldBe(new MemberInfo[] { upper, lower });
}

[TestMethod]
public void DropHiddenMembers_EmptyCurrentMembers_PreservesAllMembers()
{
MemberInfo[] members = typeof(BaseSource).GetProperties();

Filter(members, Array.Empty<MemberInfo>()).ShouldBe(members);
Filter(Array.Empty<MemberInfo>(), members).ShouldBeEmpty();
Filter(Array.Empty<MemberInfo>(), Array.Empty<MemberInfo>()).ShouldBeEmpty();
}

[TestMethod]
public void DropHiddenMembers_PrivateMemberHidesPublicMember_PreservesSelection()
{
var hidden = typeof(BaseSource).GetProperty(nameof(BaseSource.Value));
var visible = typeof(PrivateSource).GetProperty("Value", BindingFlags.NonPublic | BindingFlags.Instance);

Filter(new MemberInfo[] { hidden }, new MemberInfo[] { visible }).ShouldBeEmpty();
}

[TestMethod]
public void DropHiddenMembers_ReenumeratedResult_RecomputesSelection()
{
var first = typeof(BaseSource).GetProperty(nameof(BaseSource.Value));
var second = typeof(DerivedSource).GetProperty(nameof(DerivedSource.Value), BindingFlags.Public | BindingFlags.Instance | BindingFlags.DeclaredOnly);
var current = new List<MemberInfo> { second };
var result = Filter(new MemberInfo[] { first, second }, current);

result.ToArray().ShouldBe(new MemberInfo[] { second });
current[0] = first;
result.ToArray().ShouldBe(new MemberInfo[] { first });
}

[TestMethod]
public void Adapt_HiddenProperty_UsesDerivedValueAndInheritedProperty()
{
var config = new TypeAdapterConfig();
config.NewConfig<DerivedSource, Destination>();
config.Compile();
var source = new DerivedSource { Value = "derived", Inherited = 42 };
((BaseSource)source).Value = 7;

var result = source.Adapt<Destination>(config);
var target = source.Adapt(new Destination(), config);

result.Value.ShouldBe("derived");
result.Inherited.ShouldBe(42);
target.Value.ShouldBe("derived");
target.Inherited.ShouldBe(42);
}

[TestMethod]
public void DropHiddenMembers_PropertyHidesField_PreservesSelection()
{
var hidden = typeof(FieldSource).GetField(nameof(FieldSource.Value));
var visible = typeof(PropertySource).GetProperty(nameof(PropertySource.Value), BindingFlags.Public | BindingFlags.Instance | BindingFlags.DeclaredOnly);

Filter(new MemberInfo[] { hidden, visible }, new MemberInfo[] { visible })
.ShouldBe(new MemberInfo[] { visible });
}

[TestMethod]
public void DropHiddenMembers_NameAccesses_GrowLinearly()
{
const int count = 64;
var members = Enumerable.Range(0, count)
.Select(index => new CountingMember("Member" + index, index)).ToArray();

Filter(members, members).ToArray().ShouldBe(members);

// Allow a constant number of name reads per member, but not a scan per match.
members.Sum(member => member.NameReads).ShouldBeLessThanOrEqualTo(8 * count);
}

[TestMethod]
public void DropHiddenMembers_UnmatchedCurrentMember_DoesNotReadMetadataToken()
{
var source = typeof(Source).GetProperty(nameof(Source.First));
var unmatched = new CountingMember("Unmatched");

Filter(new MemberInfo[] { source }, new MemberInfo[] { unmatched })
.ShouldBe(new MemberInfo[] { source });
}

private sealed class CountingMember : MemberInfo
{
private readonly string _name;
private readonly int? _token;

public CountingMember(string name, int? token = null)
{
_name = name;
_token = token;
}

public int NameReads { get; private set; }
public override string Name
{
get
{
NameReads++;
return _name;
}
}

public override int MetadataToken => _token ?? throw new InvalidOperationException("Unexpected token access");
public override Type DeclaringType => typeof(Source);
public override Type ReflectedType => typeof(Source);
public override MemberTypes MemberType => MemberTypes.Property;
public override object[] GetCustomAttributes(bool inherit) => throw new NotSupportedException();
public override object[] GetCustomAttributes(Type attributeType, bool inherit) => throw new NotSupportedException();
public override bool IsDefined(Type attributeType, bool inherit) => throw new NotSupportedException();
}

private static IEnumerable<MemberInfo> Filter(IEnumerable<MemberInfo> source, ICollection<MemberInfo> current)
{
return source.DropHiddenMembers(current);
}

private sealed class CountingCollection : ICollection<MemberInfo>
{
private readonly MemberInfo[] _members;
public CountingCollection(MemberInfo[] members) => _members = members;
public int Enumerations { get; private set; }
public int Count => _members.Length;
public bool IsReadOnly => true;
public IEnumerator<MemberInfo> GetEnumerator()
{
Enumerations++;
return ((IEnumerable<MemberInfo>)_members).GetEnumerator();
}
IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
public bool Contains(MemberInfo item) => _members.Contains(item);
public void CopyTo(MemberInfo[] array, int index) => _members.CopyTo(array, index);
public void Add(MemberInfo item) => throw new NotSupportedException();
public void Clear() => throw new NotSupportedException();
public bool Remove(MemberInfo item) => throw new NotSupportedException();
}

public class BaseSource
{
public int Value { get; set; }
public int Inherited { get; set; }
}

public class DerivedSource : BaseSource
{
public new string Value { get; set; }
}

public class FieldSource : BaseSource
{
public new int Value;
}

public class CaseSource : BaseSource
{
public int value { get; set; }
}

public class PropertySource : FieldSource
{
public new string Value { get; set; }
}

public class PrivateSource : BaseSource
{
private new int Value { get; set; }
}

public class Destination
{
public string Value { get; set; }
public int Inherited { get; set; }
}

public class Source
{
public int First { get; set; }
public int Second { get; set; }
public int Third { get; set; }
}
}
}
11 changes: 11 additions & 0 deletions src/Mapster.Tool.Tests/Helpers/ConfigHelpers.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
using System.Reflection;

namespace Mapster.Tool.Tests.Helpers
{
internal static class ConfigHelpers
{
internal static MapperOptions optMappers => new MapperOptions() { Assembly = Assembly.GetExecutingAssembly().Location, Output = Path.GetTempPath() };
internal static ModelOptions optModels = new ModelOptions() { Assembly = Assembly.GetExecutingAssembly().Location, Output = Path.GetTempPath() };
internal static ExtensionOptions optExtentions = new ExtensionOptions() { Assembly = Assembly.GetExecutingAssembly().Location, Output = Path.GetTempPath() };
}
}
6 changes: 1 addition & 5 deletions src/Mapster.Tool.Tests/Mapster.Tool.Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,17 +1,13 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks>
<TargetFrameworks>$(MapsterToolTFMs)</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsTestProject>true</IsTestProject>
<IsPackable>false</IsPackable>
</PropertyGroup>

<PropertyGroup Condition=" '$(OS)' == 'Windows_NT' ">
<TargetFrameworks>$(TargetFrameworks);net48</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="FluentAssertions" Version="7.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
Expand Down
4 changes: 3 additions & 1 deletion src/Mapster.Tool.Tests/Usings.cs
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
global using Xunit;
global using Xunit;
global using Mapster.Tool;
global using Mapster.Tool.Tests.Helpers;
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,58 @@ public void MapWithReflection()
userMapper.MapTo(user, dto);
dto.Name.Should().Be(expected);
}

/// <summary>
/// https://github.com/MapsterMapper/Mapster/issues/1017
/// </summary>
[Fact]
public void CreateDtoWithcustomResolver()
{
var mappers = new List<string>();

Generators.GenerateExtensions(ConfigHelpers.optExtentions, mappers);

var result = mappers.Where(x => x.Contains("User1017Dto AdaptToDto(this User1017")).FirstOrDefault();

result.Should().NotBeNullOrEmpty();
result.Contains("FullName = string.Format(\"{0} {1}\", p1.FirstName, p1.LastName)").Should().BeTrue();
}
}



public class User1017
{
public int Id { get; set; }
public string Email { get; set; }
public string FirstName { get; set; }
public string LastName { get; set; }
public int Age { get; set; }
}

public partial class User1017Dto
{
public int Id { get; set; }
public string Email { get; set; }
public string FullName { get; set; }
public int Age { get; set; }
}


public class UserCodeGenConfig : ICodeGenerationRegister
{
public void Register(CodeGenerationConfig config)
{
config.AdaptTo("[name]Dto", MapType.Map)
.ForType<User1017>(p =>
{
p.Ignore(s => s.FirstName);
p.Map(s => s.LastName, s => $"{s.FirstName} {s.LastName}", "FullName");
});

config.GenerateMapper("[name]Mapper")
.ForType<User1017>();
}
}

public class UserMappingRegister : IRegister
Expand Down
Loading
Loading