Skip to content

Fix resolving vanity for private profiles returning error #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3urobeat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix resolving vanity for private profiles returning error #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion components/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,16 @@ exports.resolveVanityURL = function(url, callback) {
}

let steamID64 = parsed.profile.steamID64[0];
let vanityURL = parsed.profile.customURL[0];

let vanityURL;

if (parsed.profile.customURL) { // Always get customURL from XML if profile is public to support "/profiles/steamID64" urls
vanityURL = parsed.profile.customURL[0]
} else if (url.includes("steamcommunity.com/id/")) { // Get vanity from url param instead if profile is private as Steam does not include a customURL key for them
vanityURL = url.replace("https://steamcommunity.com/id/", "");
} else { // If a "/profiles/steamID64" link to a private profile was provided we cannot get the vanity
vanityURL = "";
}

callback(null, {"vanityURL": vanityURL, "steamID": steamID64});
});
Expand Down