Fix marketSearch parsing errors escaping the callback - #376
Open
tarikermis wants to merge 1 commit into
Open
tarikermis wants to merge 1 commit into
tarikermis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #198.
A malformed percent-encoded item name makes
marketSearch()throw aURIErrorfrom its HTTP response handler, so callers cannot handle the failure through their callback.This catches listing-parser errors and passes them to the existing error-first callback. Parsing stops on the failing page without returning partial results. Valid names still decode normally, and exceptions thrown by the caller’s callback still propagate.
Verification:
node test/marketSearch.malformedUri.test.jspasses with mocked responses covering malformed UTF-8, invalid percent escapes, valid Unicode, pagination, and callback exceptions. The same test fails against unchanged upstream code with the malformed-URI error.node --check classes/CMarketSearchResult.jsandgit diff --checkalso pass. No live Steam requests were used.Best Regards, Tarik