Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
========================================
Coverage 88.56% 88.56%
========================================
Files 230 230
Lines 37623 37213 -410
Branches 2367 2348 -19
========================================
- Hits 33319 32956 -363
+ Misses 4300 4253 -47
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
geonnave
force-pushed
the
lh2-no-capture
branch
6 times, most recently
from
October 16, 2026 14:08
25f4599 to
d7e5396
Compare
Breaking: removes collect --device, --reads, --timeout and --retries, and POST /controller/calibration/session/capture. The bootloader's READY-mode capture they triggered is gone from swarmit, which drops request_lh2_capture and LH2_CALIB_TAG, so the two land together. On the simulator the simulated robot now presses its button at each point. AI-assisted: Claude Opus 5.5
AI-assisted: Claude Opus 5.5
Breaking: the calibration session, its preview and its start request no longer carry `reads`, and a point's per-station reads no longer carry a `target`. The calibrate app decides how many reads a press holds. AI-assisted: Claude Opus 5.5
AI-assisted: Claude Opus 5.5
AI-assisted: Claude Opus 5.5
geonnave
force-pushed
the
lh2-no-capture
branch
from
October 16, 2026 14:38
d7e5396 to
130b88e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on main.
Corner calibration had two ways to take a point: the robot's button, with the calibrate app running, or Enter at the host, which asked a robot sitting in the bootloader's READY mode for raw LH2 captures through
--device. The button path is the one in use: it needs no address, works on any robot in view, and the calibrate app averages its own reads. The READY-mode capture is being removed from the swarmit bootloader and net core (DotBots/swarmit#177), so the host side goes with it. Corner captures now come from the robot's button only, in the CLI, the REST API and the console. The simulator's robot presses its own button for each point, so simulated sessions still run end to end.Breaking changes.
dotbot swarm calibrate-lh2 collectloses--device,--reads,--timeoutand--retries. Enter no longer captures.POST /controller/calibration/session/captureis removed.readsis refused with 422, namingreadsas removed, since the calibrate app sets its own.Release order. This host no longer imports swarmit's capture names, so it runs with swarmit before and after #177; install it first, or with #177's host release. An older PyDotBot with the new swarmit fails only on
collect --device.Validation.
test_controller::test_controller_dotbot_simulator, a known environment failure on this machine, the same one reported on dotbot/cli: add calibrate-lh2 show --next-round #331).tscclean.Left for the docs sweep before merge:
doc/cli/swarm.mdanddoc/guides/lh2-calibration.mdstill describe--deviceand Enter captures.Update. A start request still carrying
readsis now refused (422) instead of ignored. Full Python suite: 1775 passed, 2 failed (the known environment failurestest_camera_service::test_a_registration_without_controls_warns_about_nothingandtest_controller::test_controller_dotbot_simulator).