Repository navigation
Conversation
geonnave
force-pushed
the
site-init-spin-radius
branch
from
October 15, 2026 11:26
d49e80f to
9a9216c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 230 230
Lines 37623 37632 +9
Branches 2367 2368 +1
=======================================
+ Hits 33319 33328 +9
Misses 4300 4300
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
geonnave
force-pushed
the
site-init-spin-radius
branch
5 times, most recently
from
October 16, 2026 14:07
ef1666e to
201a742
Compare
AI-assisted: Claude Opus 5.5
geonnave
force-pushed
the
site-init-spin-radius
branch
from
October 16, 2026 14:38
201a742 to
3db2d61
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on main.
Problem
dotbot site init --from-calibration IDwrote a site pack withoutspin_radius_mm, even when the spins behind the calibration were measured on a floor with its own radius (a site withspin_radius_mm = 53.0). The nextcollect --spinin the new site then silently fell back to the robot model's 51.4 mm, a 3% scale error on every distance.Change
The new site takes its radius from the calibration itself rather than from the site it was collected in: each
[[track]]records theradius_mmit was solved with, which also covers a--spin-radiusoverride and survives the source site being renamed or gone. The newest round's radius is used (the most common value in it), and the site pack getsspin_radius_mm = ...besideextent_mm. A calibration with no tracks writes no key.Validation
Unit:
test_site_init_carries_the_spin_radius_overcollects in a site withspin_radius_mm = 53.0, runssite init, and reads 53.0 back from the new pack; it fails without the fix.test_calibration_spin.pyandtest_cli_site.pypass (79). Not run on hardware. Formatting (black) is deferred to the pass after review.dotbot/tests/test_calibration_spin.pydotbot/calibration/conics.pydotbot/cli/site_cmd.py