joypadtest: use joypad_get_rumble_supported instead of assuming a Rumble Pak - #994
Open
zoncabe wants to merge 1 commit into
Open
joypadtest: use joypad_get_rumble_supported instead of assuming a Rumble Pak#994zoncabe wants to merge 1 commit into
zoncabe wants to merge 1 commit into
Conversation
zoncabe
marked this pull request as ready for review
September 8, 2026 03:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
joypadtestnever exercises rumble on a GameCube controller."e165fb5 gated
joypad_get_rumble_supportedbehind whether a Rumble Pak wasattached, which obviously will never be true for a GameCube controller. The
whole point of
joypad_get_rumble_supportedis so you don't have to assumewhich controller type is connected."
Both the activation block and the status line sit behind
accessory_type == JOYPAD_ACCESSORY_TYPE_RUMBLE_PAK, so with a GameCubecontroller
joypad_set_rumble_activeis never called and theRumble:linenever prints, even though
rumble_methodisJOYPAD_RUMBLE_METHOD_GCN_CONTROLLERand the motor is available.
This switches both checks to
rumble_supported, which covers the Rumble Pak andthe GameCube controller alike.
Tested against ares with gc controller support using an xbox controller: holding A now toggles the motor
and the status line reads
Rumble: Active. Behaviour with a Rumble Pak on anN64 controller is unchanged.
Opening this as a draft because the
joypad_get_rumble_supportedcall that wason line 115, inside the
ifon line 113, moved out of thatif, and I'm notsure what the consequences of that could be.