Repository navigation
Conversation
skoklowski
reviewed
Oct 14, 2026
| } | ||
|
|
||
| if (bidderRequest.device) { | ||
| request.device = bidderRequest.device; |
There was a problem hiding this comment.
Pasowałoby to przekształcić na int, bo DAS Bidder ma ścisłe typowanie i wygląda na to, że jakby ktoś tutaj przesłał string, to całe zapytanie będzie odrzucone.
skoklowski
reviewed
Oct 14, 2026
| // Adblock detected on the page (set by dlApi as customParams.adf, the same `adf` CSR | ||
| // gets). Plain ext field so das-bidder can apply the creatives' adblock compatibility. | ||
| if (customParams.adf) { | ||
| request.ext.adf = customParams.adf; |
There was a problem hiding this comment.
To samo, co tutaj: https://github.com/DreamLab/Prebid.js/pull/99/changes#r4270960958
skoklowski
approved these changes
Oct 14, 2026
dpiwko19
force-pushed
the
feature/adshield
branch
from
October 14, 2026 13:20
3098f3a to
371d1a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information