Repository navigation
Diffsky26 updates - #116
Conversation
| ) | ||
| diffsky_objects[0].prefetch_seds(diffsky_objects) | ||
|
|
||
| skycat._prefetched_sed_batch = batch_key |
There was a problem hiding this comment.
This entire file looks like a duplicate of changes made in skycat.py. Should we remove this and just use the function defined there?
| """ | ||
| return self.getNObjects() | ||
|
|
||
| def prefetch_seds(skycat, start, stop): |
There was a problem hiding this comment.
It is correct syntax, but not referring to the first argument of this method as self can be jarring to read. This is probably the result of copying it from sed_prefetch.py.
| # and only once for the range. | ||
| sed_batch = base.get("_roman_imsim_sed_batch") | ||
| if sed_batch is not None: | ||
| skycat.prefetch_seds(*sed_batch) |
There was a problem hiding this comment.
| skycat.prefetch_seds(*sed_batch) | |
| start, stop = sed_batch | |
| skycat.prefetch_seds(start=start, stop=stop) |
|
Forgot to remove the extra file. I think these should be addressed now in new push. |
There was a problem hiding this comment.
🟡 Changes recommended
Prefetching confuses stamp numbers with catalog indices, causing valid repeated-index configurations to fail.
1 open issue
What changed in this PR
Adds Diffsky26 support to sky-catalog rendering with batch-based runtime spectral prefetching.
Changes:
- Recognizes Diffsky26 galaxies and prefetches their spectra.
- Makes object batch size configurable and passes batch bounds through both image builders.
- Adds tests for prefetch selection, caching, and bounds validation.
| File | Description |
|---|---|
| tests/test_skycat_prefetch.py | Tests prefetch behavior and validation. |
| roman_imsim/skycat.py | Adds Diffsky26 classification and spectral prefetching. |
| roman_imsim/sca.py | Configures batch sizes and exposes rendering ranges. |
Review effort: Balanced
arunkannawadi
left a comment
arunkannawadi
left a comment
There was a problem hiding this comment.
These changes don't hamper the end-to-end tests: https://github.com/DukeCosmology/roman_imsim/actions/runs/39614542590
cd2ef0a to
0f2e784
Compare
|
I tried running another end-to-end test just to be sure, but building |
No description provided.