[BenjaminRodenberg]

This PR fixes (relatively trivial) bugs that were introduced in #73 and #53.

@matthias-ibach if you can confirm that this works we can update the baseline. The buggy part if coupler.couple_to_icon_atmo should also be present in the current baseline.

Author's Todos

• I ran the pre-commit hooks and fixed all issues

[BenjaminRodenberg]

The remaining updates were introduced in #73 and should not be present in the current baseline because we created the tag before merging #73.

[BenjaminRodenberg]

It is important to note that with this branch out testcase will hang at the very final step. This is due to the changes introduced in #58 that are not yet included in the run script. Therefore we need the following fix in the runscript run_ebfm_elmer_coupling.sh:

   --start-time "20-Jan-2014 00:00" \
-  --end-time "21-Jan-2014 00:00" \
+  --end-time "21-Jan-2014 03:00" \

Background: Our testcase performs 9 steps with 0.125 days duration. pre-#58 EBFM also performed 9 steps with 0.125 for --end-time "21-Jan-2014 00:00"; post-#58 EBFM only performs 8 steps (while the remaining components still perform 9 steps) with --end-time "21-Jan-2014 00:00". The fix above prevents EBFM from exiting too early which results in the other components waiting forever.

I would not consider this a bug in EBFM but rather something we have to update in the other components or in the definition of the testcase as soon as the baseline is updated.

[matthias-ibach]

@BenjaminRodenberg I can confirm that I was able to run the run_elmer_ebfm_coupling.sh test case successfully with this branch. So, this commit could serve as our new baseline.