Skip to content

fix: move nvshmem create tensor action away from for loops since it m… - #6

Merged
ETOgaosion merged 1 commit into
te_enhancefrom
feat/cp_nvshmem_enhanced
Mar 12, 2026
Merged

ETOgaosion merged 1 commit into
te_enhancefrom
feat/cp_nvshmem_enhanced

Conversation

@Knight-of-Thunder

@Knight-of-Thunder Knight-of-Thunder commented Mar 11, 2026 •

Copy link
Copy Markdown
Collaborator

…ay cause barrier we don't want

Description

Move NVSHMEM tensor creation earlier in the code path. Avoid creating NVSHMEM tensors inside the loop, as each allocation may introduce a barrier

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ETOgaosion
ETOgaosion merged commit 3824e7b into te_enhance Mar 12, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants