!feat: json responses instead of model class instances - #553
Draft
Justin Hammond (Justintime50) wants to merge 1 commit into
Draft
!feat: json responses instead of model class instances#553Justin Hammond (Justintime50) wants to merge 1 commit into
Justin Hammond (Justintime50) wants to merge 1 commit into
Conversation
Justin Hammond (Justintime50)
force-pushed
the
428_json_formatted_responses
branch
from
July 28, 2026 18:31
9c2501b to
8f52491
Compare
Matthew Banbury (bnbry)
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
API resource responses are now plain JSON-compatible objects rather than model class instances.
Retains json-compatible response objects, instance helper methods like
lowestRate, and instanceof model checks from before.Closes #428
Testing
Ran a one-off test to ensure printed json responses were plain JSON and not instance model classes. Test suite also passes with no test-suite changes.
Pull Request Type
Please select the option(s) that are relevant to this PR.