Skip to content

fix: updating char lenghth - #121

Merged
TEJASNARAYANS merged 1 commit into
mainfrom
metric-char-length
Aug 27, 2026
Merged

fix: updating char lenghth#121
TEJASNARAYANS merged 1 commit into
mainfrom
metric-char-length

Conversation

@TEJASNARAYANS

@TEJASNARAYANS TEJASNARAYANS commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

What Changed?

Briefly describe what this PR changes.

Why?

Explain the problem this solves and why this approach was chosen.

How to Test?

List clear steps for reviewers to verify the change.

Release Label

Select one semantic version bump intent for this PR:

  • major - breaking change, next release bumps major version
  • minor - backward-compatible feature, next release bumps minor version
  • fix - backward-compatible bug fix, next release bumps patch version
  • No label (defaults to patch release)

If you do not have permission to apply labels, mention the intended release label here and a maintainer will set it.

Checklist

  • I have read the CONTRIBUTING.md guide.
  • My code follows the project's style guidelines.
  • I have added tests that prove my fix is effective or my feature works.
  • I have updated documentation where needed.

@TEJASNARAYANS TEJASNARAYANS added the fix Fix version release label Aug 27, 2026
@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown

Greptile Summary

This PR raises the metric-rubric text limit from 32,000 to 1,000,000 characters, applies the shared limit to standalone metric descriptions, and expands boundary validation tests.

  • Consolidates the rubric-size constant and applies it consistently across metric create, update, and child schemas.
  • Adds acceptance tests at the new boundary and rejection tests immediately above it.
  • The accepted size can exceed downstream LLM context limits because evaluation prompts have no corresponding aggregate size guard.

Confidence Score: 4/5

The PR should not merge until accepted rubric sizes are bounded for downstream evaluation prompts or oversized prompts are handled explicitly.

Metric payloads near the new limit pass API validation and persistence but are inserted into bounded LLM contexts without aggregate prompt-size enforcement, so later evaluations can fail despite the metric being accepted.

Files Needing Attention: app/models/schemas.py

Important Files Changed

Filename Overview
app/models/schemas.py Raises rubric fields to a one-million-character validation limit, allowing persisted metrics that can overflow downstream evaluation prompts.
tests/test_models/test_metric_rubric_max_length.py Expands coverage across standalone, hierarchical, and update schemas at and above the shared boundary.

Reviews (1): Last reviewed commit: "fix: updating char lenghth" | Re-trigger Greptile

Comment thread app/models/schemas.py
@TEJASNARAYANS
TEJASNARAYANS merged commit 26b82ac into main Aug 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fix version release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant