Skip to content

Implement (experimental!) fetch of bolt11 invoices from (simple) offers - #9168

Open
rustyrussell wants to merge 6 commits into
ElementsProject:masterfrom
rustyrussell:guilt/fetch-bolt11
Open

Implement (experimental!) fetch of bolt11 invoices from (simple) offers#9168
rustyrussell wants to merge 6 commits into
ElementsProject:masterfrom
rustyrussell:guilt/fetch-bolt11

Conversation

@rustyrussell

@rustyrussell rustyrussell commented May 26, 2026

Copy link
Copy Markdown
Collaborator

As per spec draft at lightning/bolts#1336

@rustyrussell rustyrussell added this to the v26.09 milestone May 26, 2026
@rustyrussell
rustyrussell requested a review from cdecker as a code owner May 26, 2026 12:49
@madelinevibes madelinevibes added the Status::Ready for Review The work has been completed and is now awaiting evaluation or approval. label Jun 17, 2026
@madelinevibes
madelinevibes requested a review from nGoline June 17, 2026 06:33
@nGoline
nGoline force-pushed the guilt/fetch-bolt11 branch 3 times, most recently from a4c93d3 to 51a01c5 Compare July 2, 2026 16:17
@nGoline
nGoline requested review from sangbida and removed request for nGoline July 2, 2026 16:24
@Lagrang3
Lagrang3 self-requested a review July 29, 2026 09:18
…sts.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We hit this:

```
Bad invoice error {"code":-32602,"message":"Label 'c4f9d891047a770bb96953886ad9536cd4eb43f0dd4423dcd9a7b4952a615a8c-031f952d09872d0c45bfc81e3fb1d9c193647c176362f290f104c1d719547b044b-0' over 128 bytes"}
```

I'm not sure why it was there, but it's been there since the very early days.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…equested.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-EXPERIMENTAL: Protocol: `offer` now sets the feature to allow experimental request of a bolt11 invoice, for simple offers.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is the experimental proposal to allow bolt11 replies to fetchinvoice.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-EXPERIMENTAL: JSON-RPC: `fetchinvoice` can fetch bolt11 invoices, if supported.
@rustyrussell rustyrussell modified the milestones: v26.09, v26.12 Aug 24, 2026
@rustyrussell

Copy link
Copy Markdown
Collaborator Author

Rebased, updated for inclusion in v26.12 (if it is for v26.09, just fix up the two "added" schema changes...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status::Ready for Review The work has been completed and is now awaiting evaluation or approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants