Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Molto.embeddings()with a typed OpenAI request and parsed SDK result, native OpenAI-compatible transport for OpenAI/Infinity/vLLM, and Cohere v2/VoyageAI text embedding translation. Endpoint, provider, and destination remain independent; self-hosted routes require an explicit URL.None. Unsupported multimodal/contextual, quantized, sparse, and multiple-vector semantics fail explicitly. Shared HTTP lifecycle, credentials, header filtering, and error conventions are reused without new runtime dependencies, streaming, or automatic batching.Emptyvalue.Draft; related to #93. OpenAI (
text-embedding-3-small) and Cohere (embed-v4.0) have successful live captures. VoyageAI's available credentials returned 401; the configured vLLM server timed out; Infinity was unconfigured. VoyageAI success coverage is synthetic. Infinity 3.0.0 and vLLM 0.33.0 are pinned source/schema references, not live-tested server/model claims. The issue remains open until successful evidence establishes all five integrations.Verification
uv run --extra test pytest -q --tb=short: 1,625 passed; replay only, including existing conversational regressions.uv run --extra test pytest -q --tb=short tests/test_embedding_translation.py tests/core/test_embeddings.py: 108 passed.uv run --extra test pytest -q --tb=short tests/core/test_embedding_engines.py: 56 passed; corrected synthetic error also passed focused replay.uv run --extra lint ruff check --output-format github --config pyproject.toml .: passed.uv run --extra lint ruff format --diff --config pyproject.toml .: passed, 100 files.npx prettier@3.8 --check .: passed; final matrix wording also passed a focused check.git diff --checkand recorded-fixture integrity checks: passed.gh pr checks 97 --repo EmbeddedLLM/molto --watch --interval 10: all checks passed, including Python 3.12, 3.13, and 3.14, Ruff, and Prettier.