Repository navigation
Conversation
Collaborator
|
The code looks fine so far. Some performance metrics in an eval, for example? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my implementation of PDM from the "Parting with misconceptions" paper of D. Dauner et al.
It has a lot of parameters, and I put in the default values the one that I found to work best in PufferDrive but everyone should tune it to what it wants, there's a tradeoff in compute time vs performance (coming mostly from planning_dt and planning_horizon but also from the number of candidate trajectories you consider)