Keep the updater away from the install package - #297
Merged
Merged
Conversation
The new ignis-<version>-install.zip release asset matches the updaters ignis-*.zip preference, so depending on asset order it would have downloaded the install package instead of the app archive and extracted a zip-in-a-zip. Skip -install.zip assets explicitly.
✅ Alle Checks bestanden1 Dateien geändert · Übersicht
Unit Tests ✅
Integration Tests ✅
Feature Tests (HTTP) ✅
Frontend Build ✅
PHPStan – Statische Analyse ✅
Security Audit ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #296. The updater prefers
ignis-*.ziprelease assets, and the newignis-<version>-install.zipmatches that prefix - depending on the asset order GitHub returns, an in-app update would have grabbed the install package (setup.php + nested archive) instead of the app archive. The asset loop now skips-install.zipexplicitly. The standalone setup wizard got the same guard in EmergencyForge/ignis-setup@8b74f4c.