Fix the backlog: dropdowns under dialogs, incidents that never close - #384
Merged
Merged
Conversation
Rebuild against the ui package, which now lifts a panel moved to <body> one level above the modal its trigger sits in. Before, the panel shared the backdrop's z-index and slid under the dialog or drawer window, leaving only the part that stuck out below it visible. The report on the board came from 1.2.0's canvas template editor, where the field type picker showed "Text" and its last three options. That editor is gone since the switch to the shared document editor; the same layering bug was still there for the dropdowns and date pickers in the logbook and defect forms. Also carries the motion primitives the package gained on 2026-09-14, which had not been built into ignis yet.
addLabels answers the bot app's token with 403 "Resource not accessible by integration", and issues.create drops labels silently for the same reason. No incident ever carried a label — and since dedup and the close-on-green step both searched by label, none was ever found again. #374 and #375 stayed open for ten days after main went green. Labels and closing now go through GITHUB_TOKEN, which the workflow already grants issues: write. Open incidents are found by the marker in their body rather than by label, so the ones created without labels are picked up too.
✅ Alle Checks bestanden7 Dateien geändert · Übersicht
Unit Tests ✅
Integration Tests ✅
Feature Tests (HTTP) ✅
Frontend Build ✅
PHPStan – Statische Analyse ✅
Security Audit ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from the backlog, plus the reason two incident issues sat open for ten days.
Dropdowns under the dialog (ForgeBoard #112)
The ui package moves a dropdown's or date picker's panel to
<body>so no overflow container clips it. It then sat on z-index 2000, the dialog backdrop's level, one below the dialog window. Inside a dialog or drawer the panel slid under the window and only the part hanging out below it stayed visible.The report came from 1.2.0's canvas template editor ("Text" plus the last three field types). That editor is gone on main, but the logbook and defect forms have the same kind of dropdown in a drawer. The package fix is
EmergencyForge/WebPackages@ed50458; this PR carries the rebuilt assets.Incidents that never closed (#374, #375)
addLabelsgets a 403 from the bot app's token, andissues.createdrops labels silently for the same reason. No incident has ever carried a label, and since dedup and close-on-green both searched by label, none was found again. Labels and closing now useGITHUB_TOKEN; open incidents are found by the marker in their body.Both incidents were already fixed on main: #374 by c991962 (
User::create()in a new test), #375 by 65cad3d (tailwind.css not rebuilt).Closes #374
Closes #375