Skip to content

check out submodules in ci - #36

Merged
siahisaforker merged 1 commit into
ExpansionPak:mainfrom
dougchansan:ci/checkout-submodules
Oct 10, 2026
Merged

siahisaforker merged 1 commit into
ExpansionPak:mainfrom
dougchansan:ci/checkout-submodules

Conversation

@dougchansan

Copy link
Copy Markdown
Contributor

c876e2b added tomlc17 as a submodule, but ci checks out without submodules, so every job stops at configure with tomlc17 submodule is missing. this fetches them in both jobs.

c876e2b added the tomlc17 submodule, so every job now stops at configure.
@dougchansan

Copy link
Copy Markdown
Contributor Author

@siahisaforker with submodules fetched, the remaining red jobs (here and on #35 / #37) are all tests/modern_memory_service_test.c, which is already failing on main:

  • msvc: __asm__("func_...") labels don't compile
  • macos: the labels miss the _ symbol prefix, so it fails to link
  • windows mingw: segfaults at runtime (reproduces locally with clang too). probably the 28-byte MGNativeExit return not matching the win64 abi

it's only the moderngekko runtime path, so i've left it alone.

@siahisaforker

Copy link
Copy Markdown
Contributor

should be good to go, thanks

@siahisaforker
siahisaforker merged commit e8bbb0f into ExpansionPak:main Oct 10, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants