Repository navigation
fix modern_memory_service on windows and macos - #38
Merged
siahisaforker merged 2 commits intoOct 10, 2026
Merged
siahisaforker merged 2 commits into
siahisaforker merged 2 commits into
Conversation
the fifo partial write called the service directly and read its 16-byte result from registers, but win64 returns that struct through a hidden pointer, so it segfaulted. call it through a c helper like read/write memory do. the test's asm labels also missed the macos symbol prefix and don't exist on msvc; use __USER_LABEL_PREFIX__ there and a linker alias on msvc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the three red llvm jobs on main.
write_fifo_partialdirectly and read the 16-byteMGNativeMemoryResultfrom registers. win64 returns that struct through a hidden pointer, so args shifted and it crashed. it now goes through amoderngekko_write_fifo_partialc helper, same as read/write memory.__asm__("func_...")labels missed the_prefix. it now uses__USER_LABEL_PREFIX__./alternatenamelinker aliases.all 35 tests pass locally on windows with clang, and the test compiles with msvc. macos is untested locally.