Conversation
…ndaries ### Description This PR addresses critical cryptographic validation vulnerabilities across the `ArbitrumContracts`, `arbitrum-contracts-audit`, and `debid-audit` repositories. **Vulnerabilities & Security Defects Remediated:** * **Cryptography / Attacker-Controlled Panic Paths (`decrypter-contract/src/lib.rs`):** Previously, malformed age headers, recipients, compressed points, recipient bodies, base64 payloads, and invalid key material could trigger panics through unchecked parsing and unwrapping. The duplicated implementations have been hardened to strictly validate lengths and parser results before performing any indexing or curve operations. All attacker-controlled panic paths (e.g., `unwrap`, `expect`) have been successfully replaced with fallible decoding and typed contract errors (e.g., `BAD_G1`, `LEN_ERR`, `PARSE_ERR`, `MAC_ERR`), ensuring the contract fails safely rather than terminating execution abruptly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses critical cryptographic validation vulnerabilities across the
ArbitrumContracts,arbitrum-contracts-audit, anddebid-auditrepositories.Vulnerabilities & Security Defects Remediated:
decrypter-contract/src/lib.rs): Previously, malformed age headers, recipients, compressed points, recipient bodies, base64 payloads, and invalid key material could trigger panics through unchecked parsing and unwrapping. The duplicated implementations have been hardened to strictly validate lengths and parser results before performing any indexing or curve operations. All attacker-controlled panic paths (e.g.,unwrap,expect) have been successfully replaced with fallible decoding and typed contract errors (e.g.,BAD_G1,LEN_ERR,PARSE_ERR,MAC_ERR), ensuring the contract fails safely rather than terminating execution abruptly.