Document EFFECTS_THRESHOLD default change in v4.20.2 - #562
Merged
Conversation
Co-authored-by: dudizimber <16744955+dudizimber@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Change EFFECTS_THRESHOLD default to 0 from FalkorDB version 4.20.2 onwards
Document EFFECTS_THRESHOLD default change in v4.20.2
Sep 2, 2026
dudizimber
reviewed
Sep 2, 2026
| #### Default | ||
|
|
||
| `EFFECTS_THRESHOLD` is 300 μs. | ||
| Starting with FalkorDB v4.20.2, `EFFECTS_THRESHOLD` is 0 μs. |
Co-authored-by: dudizimber <16744955+dudizimber@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation update is accurate and scoped to the stated version boundary, with only minor wording consistency feedback.
Pull request overview
Updates the FalkorDB core configuration documentation to reflect the EFFECTS_THRESHOLD default change introduced in FalkorDB v4.20.2, aligning the docs with the new runtime behavior referenced by issue #561.
Changes:
- Updated the documented default for
EFFECTS_THRESHOLDto clarify it was300 μsbefore v4.20.2 and is0 μsstarting with v4.20.2. - Added an explicit version boundary to avoid ambiguity for users on older releases.
File summaries
| File | Description |
|---|---|
| getting-started/configuration.mdx | Clarifies the EFFECTS_THRESHOLD default and adds the v4.20.2 cutoff in the configuration reference. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
DvirDukhan
approved these changes
Sep 2, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is documentation-only and correct, with only a minor wording/convention consistency nit noted.
Review details
Suppressed comments (1)
getting-started/configuration.mdx:406
- In this file, “Default” entries consistently start with the parameter name (e.g.,
CMD_INFOis…,MAX_INFO_QUERIESis…), which makes the section easy to scan. This default sentence starts with the version boundary instead, which breaks that pattern; consider leading withEFFECTS_THRESHOLDand repeating it in the second clause to avoid the ambiguous “it”.
Before FalkorDB v4.20.2, `EFFECTS_THRESHOLD` is 300 μs. Starting with FalkorDB v4.20.2, it is 0 μs.
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EFFECTS_THRESHOLDdefaults to0 μsstarting with FalkorDB v4.20.2.